Update desktop access docs for 9.0 #10406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zmb3
commented
Feb 16, 2022
zmb3
commented
- Remove admonition about being in preview
- Add audit events listing
- Break reference.mdx up into separate pages
zmb3
force-pushed
the
zmb3/docs-desktop-90
branch
2 times, most recently
from
849f098 to
1aafaa9
Compare
ptgott
reviewed
Feb 17, 2022
r0mant
approved these changes
Feb 18, 2022
zmb3
force-pushed
the
zmb3/docs-desktop-90
branch
4 times, most recently
from
1b334c8 to
e5efa39
Compare
ptgott
reviewed
Feb 22, 2022
docs/pages/desktop-access/rbac.mdx
Outdated
|
|
||
| The `windows_desktop_logins` role setting lists the Windows user accounts that | ||
| the role permits access to. Like with SSH access, the | ||
| `{{internal.windows_logins}}` variable can be used for local users, which maps |
There was a problem hiding this comment.
Is another wording of this sentence "...local users maps to any logins..."? I may not be reading it correctly.
In any case, I think we should rework the sentence beginning "Like with SSH access" so users don't need to understand our Server Access documentation before they can follow this guide.
|
Took another stab, let me know if that reads better. |
ptgott
approved these changes
Feb 22, 2022
- Remove admonition about being in preview - Add audit events listing - Break reference.mdx up into separate pages
zmb3
force-pushed
the
zmb3/docs-desktop-90
branch
from
9208f7b to
87b8e62
Compare
zmb3
added a commit
that referenced
this pull request
Feb 23, 2022
* Update desktop access docs for 9.0 - Remove admonition about being in preview - Add audit events listing - Break reference.mdx up into separate pages * Update tile icons * Address review suggestions * Another review pass
zmb3
added a commit
that referenced
this pull request
Feb 25, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.